phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Updates to slider range, constrainValue #148

Closed arouinfar closed 4 years ago

arouinfar commented 4 years ago

This stems from #147, but is a general design change so creating a separate issue.

Amplitude:

Frequency:

Pulse Width:

Damping:

jonathanolson commented 4 years ago

Should be implemented in the above commit, can you verify?

arouinfar commented 4 years ago

@jonathanolson the ranges and thumb snapping looks good in master, but the tweaker increment should still be the smallest possible step size.

jonathanolson commented 4 years ago

I believe that should be fixed, apologies! NumberControl is generally set up to use the same step sizes for the buttons and slider.

arouinfar commented 4 years ago

Looks great, thanks @jonathanolson!