phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Code review for the model #21

Closed jonathanolson closed 10 years ago

jonathanolson commented 10 years ago

I've marked up WOASModel with "//REVIEW' comments. Please respond to (or fix) these, and let me know if there are any problems, if this work was not agreed to, or if anything seems incorrect.

"REVIEW: performance" indicates something that should help improve the sim's performance, and "REVIEW: doc" indicates a place where I would like to see a bit of documentation (a few places I added my interpretation of what the documentation would say).

I've also created https://github.com/phetsims/wave-on-a-string/issues/16, https://github.com/phetsims/wave-on-a-string/issues/17 and https://github.com/phetsims/wave-on-a-string/issues/18, discovered from reviewing the code, which can be handled separately.