phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Scaling of ruler is inaccurate. #43

Closed orejolaphet closed 10 years ago

orejolaphet commented 10 years ago

The scaling of the ruler seems to be off. First off, I'm not exactly sure what the units of the ruler are as it states "0 cm" but the tick marks are in increments of 5. This leaves it pretty ambiguous to the units of the ruler. screen shot 2014-01-31 at 1 58 15 pm In this picture the red dotted line represents the amplitude of the pulse. Notice the amplitude is set to the default 1.5 cm, but the dotted line falls no where near what could be interpreted as 1.5 cm. If the ruler were in inches then 1.5cm = 0.56in which the red dotted line is not near as well. This should be fixed.

jonathanolson commented 10 years ago

There are three main ways to fix this:

  1. Adjust the ruler's scale, optionally keeping the ruler's thickness
  2. Adjust the string to match the size shown on the rulers
  3. Adjust the amplitude range, leaving the visual string behavior (X pixels high for Y percent amplitude of max) the same

Any preferences?

ariel-phet commented 10 years ago

The amplitude here is fairly arbitrary, so I would leave the rulers "as is" and adjust the amplitude range (the strings visual behavior is very nice as is)