Possible fix for heroku deployment

pheuter / essential-react

A minimal skeleton for building testable React apps using Babel

MIT License

2.02k stars 131 forks source link

Possible fix for heroku deployment #26

Closed Dylanb-dev closed 8 years ago

Dylanb-dev commented 8 years ago

I made a couple of changes to make the app deployable on heroku as it gave an error before.

I'm very novice with webpack and with the process.env.PRODUCTION variable so my solution is probably incorrect.

pheuter commented 8 years ago

Yeah, master is currently working towards release v0.4.0 which is still a WIP. One of the things left to do is to make sure the Heroku button still works. I believe the latest issue is around not installing node devDependencies, which currently are required to build the app.

I don't think a Procfile is necessary for a Heroku button deploy, should be as simple as setting configuration in the app.json file to install all node modules.

Dylanb-dev commented 8 years ago

Didn't mean to close this, I have made the modification to app.json.

pheuter commented 8 years ago

sweet, thanks! has this been tested in a sample deploy?

Dylanb-dev commented 8 years ago

Yes, pressing the deploy button on my fork deployed with no errors. Result: https://er-deploy-fix.herokuapp.com/

pheuter commented 8 years ago

:+1: