pheuter / essential-react

A minimal skeleton for building testable React apps using Babel
MIT License
2.02k stars 131 forks source link

Node v6.0.0 support? #39

Open iominh opened 8 years ago

iominh commented 8 years ago

Hi @pheuter, thanks for this great boilerplate! Have you tested support for v6.0.0 on the v0.5.0 branch? I'm noticing better npm install speeds (a clean install went from 3m45s to 2m2s in real time when comparing node v5.7.1 vs v6.0.0) but am running into the following error with Node v6.0.0 and npm 3.8.6:

npm run server

> essential-react@0.5.0 server /wrk/essential-react-node6
> node start.js

Essential React listening at http://:::8080
Container#eachAtRule is deprecated. Use Container#walkAtRules instead.
Container#eachRule is deprecated. Use Container#walkRules instead.
Container#eachDecl is deprecated. Use Container#walkDecls instead.
Node#before is deprecated. Use Node#raws.before
Node#removeSelf is deprecated. Use Node#remove.
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x11f505dc9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2316ffd24064] (this=0x12e9cee0a999 <an Object with map 0x18348d491841>#1#,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:~447] [pc=0x2316ff4e79d6] (this=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2316ff33899d] (this=0x11f505d04189 <undefined>,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x2316ff92298b=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04101 <null>)
  165: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:52] [pc=0x2316ff6bf525] (this=0x11f505de99f1 <JS Global Object>#37#)
  166: arguments adaptor frame: 1->0
  167: done [/wrk/essential-react-node6/node_modules/async/lib/async.js:~238] [pc=0x2316ff452da4] (this=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04189 <undefined>)
  168: arguments adaptor frame: 0->1
  169: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:44] [pc=0x2316ff66f0d4] (this=0x11f505de99f1 <JS Global Object>#37#)
  170: /* anonymous */ [/wrk/essential-react-node6/node_modules/webpack/lib/Compilation.js:332] [pc=0x2316ff85c261] (this=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04101 <null>)
  171: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:52] [pc=0x2316ff6bf525] (this=0x11f505de99f1 <JS Global Object>#37#)
  172: arguments adaptor frame: 1->0
  173: done [/wrk/ess
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x2316ff20961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x11f505dc9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2316ffd24064] (this=0x12e9cee0a999 <an Object with map 0x18348d491841>#1#,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:~447] [pc=0x2316ff4e79d6] (this=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2316ff33899d] (this=0x11f505d04189 <undefined>,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x2316ff92298b
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x2316ff20961b
yanndupuy commented 8 years ago

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

dupuyyann@gmail.com Domain zyapps.com has exceeded the max emails per hour (416/400 (104%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 16506 characters long; only the first ------ 5000 or so are included here. Received: from github-smtp2-ext3.iad.github.net ([192.30.252.194]:42957 helo=github-smtp2b-ext-cp1-prd.iad.github.net) by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from noreply@github.com) id 1avrwD-001GUy-GY for yann.dupuy@zyapps.com; Thu, 28 Apr 2016 21:49:27 +0200 Date: Thu, 28 Apr 2016 12:48:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1461872922; bh=96faBcyjEhqAM73x43J5WBf+EbHTOVsjEaHttB08kAE=; h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=R1T+8T0Ll6GlwOJrtpp0GsHGK7xAJkZ/Gintt/H7RrbjbjwAo3+k+OPtcI4YWXoUJ F4Tr37mdPNIlVF+5GpGbSTSHyTbRBlYVnbrUAkHLMT5UdZlhRo3K4mPen7MC/lD11O 0BgbnexFkZEfqpc1d/tctWqEY2AEyngmpYW1kLyk= From: Minh Nguyen notifications@github.com Reply-To: pheuter/essential-react reply@reply.github.com To: pheuter/essential-react essential-react@noreply.github.com Cc: Message-ID: pheuter/essential-react/issues/39@github.com Subject: [pheuter/essential-react] Node v6.0.0 support? (#39) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5722691aa2f1b_6d463fc4bd06f2b81172b1"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: iominh X-GitHub-Recipient: yanndupuy List-ID: pheuter/essential-react List-Archive: https://github.com/pheuter/essential-react List-Post: mailto:reply@reply.github.com List-Unsubscribe: mailto:unsub+000df0dc71f21ec4ff653d0f350a538204d1740fd812e18692cf00000001133a2b1a92a169ce090b2d42@reply.github.com, https://github.com/notifications/unsubscribe/AA3w3EwxC2f_7yl9zsO_Cp-d-x1xWugAks5p8Q8agaJpZM4ISQ-W X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: yann.dupuy@zyapps.com X-Spam-Status: No, score=-0.1 X-Spam-Score: 0 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details.

Content preview: Hi @pheuter, thanks for this great boilerplate! Have you tested support for v6.0.0 on the v0.5.0 branch? I'm noticing better npm install speeds (a clean install went from 3m45s to 2m2s in real time when comparing node v5.7.1 vs v6.0.0) but am running into the following error with Node v6.0.0 and npm 3.8.6: [...]

Content analysis details: (-0.1 points, 5.0 required)

pts rule name description


0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.com] 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-Spam-Flag: NO

----==_mimepart_5722691aa2f1b_6d463fc4bd06f2b81172b1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi @pheuter, thanks for this great boilerplate! Have you tested support for v6.0.0 on the v0.5.0 branch? I'm noticing better npm install speeds (a clean install went from 3m45s to 2m2s in real time when comparing node v5.7.1 vs v6.0.0) but am running into the following error with Node v6.0.0 and npm 3.8.6:

npm run server

> essential-react@0.5.0 server /wrk/essential-react-node6
> node start.js

Essential React listening at http://:::8080
Container#eachAtRule is deprecated. Use Container#walkAtRules instead.
Container#eachRule is deprecated. Use Container#walkRules instead.
Container#eachDecl is deprecated. Use Container#walkDecls instead.
Node#before is deprecated. Use Node#raws.before
Node#removeSelf is deprecated. Use Node#remove.
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x11f505dc9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2316ffd24064] (this=0x12e9cee0a999 <an Object with map 0x18348d491841>#1#,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:~447] [pc=0x2316ff4e79d6] (this=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2316ff33899d] (this=0x11f505d04189 <undefined>,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x2316ff92298b=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04101 <null>)
  165: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:52] [pc=0x2316ff6bf525] (this=0x11f505de99f1 <JS Global Object>#37#)
  166: arguments adaptor frame: 1->0
  167: done [/wrk/essential-react-node6/node_modules/async/lib/async.js:~238] [pc=0x2316ff452da4] (this=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04189 <undefined>)
  168: arguments adaptor frame: 0->1
  169: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:44] [pc=0x2316ff66f0d4] (this=0x11f505de99f1 <JS Global Object>#37#)
  170: /* anonymous */ [/wrk/essential-react-node6/node_modules/webpack/lib/Compilation.js:332] [pc=0x2316ff85c261] (this=0x11f505de99f1 <JS Global Object>#37#,err=0x11f505d04101 <null>)
  171: /* anonymous */ [/wrk/essential-react-node6/node_modules/async/lib/async.js:52] [pc=0x2316ff6bf525] (this=0x11f505de99f1 <JS Global Object>#37#)
  172: arguments adaptor frame: 1->0
  173: done [/wrk/ess
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x2316ff20961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x11f505dc9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2316ffd24064] (this=0x12e9cee0a999 <an Object with map 0x18348d491841>#1#,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:~447] [pc=0x2316ff4e79d6] (this=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2316ff33899d] (this=0x11f505d04189 <undefined>,module=0x3893efda2921 <a Module with map 0x18348d4181b9>#2#,filename=0x3893efda28f9 <String[97]: /wrk/essential-react-node6/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x2316ff92298b
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v