fixing Heroku deployment

pheuter / essential-react

A minimal skeleton for building testable React apps using Babel

MIT License

2.02k stars 131 forks source link

fixing Heroku deployment #45

Open sizov opened 8 years ago

sizov commented 8 years ago

This fixes issues when deploying to Heroku, #41

import for ES6 modules is not supported yet natively, but server.js has import statement. This project does not build server.js with any build tool to augument import, so nodejs fails on that import line, had to fix it
if you deploy to Heroku from command line, environment variables in app.json are ignored, so you need to set them manually

coveralls commented 8 years ago

Changes Unknown when pulling c36e3627628fdb3297998b938ca5a876516ad82e on sizov:master into \ on pheuter:master**.

sizov commented 8 years ago

@coveralls looks fine here, I've tried to git clone original repo from scratch, then add my remote as upstream and was able to fetch and merge changes from my repo into this.

mdoerneman commented 8 years ago

@sizov Thank you! This was extremely helpful to get things working on Heroku.