phgDigital / Project

1 stars 1 forks source link

Apply pointer to custom menu object with no href #15

Closed phgDigital closed 7 years ago

phgDigital commented 7 years ago

I think it could be as easy as adding cursor: pointer; to the following line: https://github.com/chrisblakley/Nebula/blob/8eb2164a66425b1d2f2b6c4993fd74dd41327fdb/assets/scss/style.scss#L412

chrisblakley commented 7 years ago

I personally think that the implied UX of this is appropriate as-is. The pointer cursor indicates that a link is clickable, so if there is not an href associated with a link my thought is that it should not get a pointer.

We could handle this at a project-specific level, but I think my opinion is that the by-the-book way to fix this is to not have unlinked <a> tags.