search

phgDigital / Project

1 stars 1 forks source link

Nebula Favicon Displays in Admin -> Nebula Options #18

Closed phgDigital closed 7 years ago

phgDigital commented 7 years ago

Curious if this is supposed to happen. I noticed it happening in nebula options and when adjusting the menu.

phgDigital commented 7 years ago

Screenshots: image

chrisblakley commented 7 years ago

That one might be a cache issue. I've seen it on other projects that don't immediately update the meta graphics. On mine I'm seeing the correct favicon in the tab.

However, I'm also seeing this: screen shot 2017-07-19 at 12 04 38 pm

Which I think needs to add a conditional for the Customizer site_icon.

chrisblakley commented 7 years ago

Ok, I've fixed the dashboard icon.

get_site_icon_url(32, get_theme_file_uri('/assets/img/meta') . '/favicon-32x32.png')
chrisblakley commented 7 years ago

I'm actually going to close this unless we determine it needs to be revisited.