search

phhusson / Superuser

Keeping koush's Superuser fresh
GNU General Public License v3.0
424 stars 50 forks source link

Android 4.2 compatibility #24

Open revuwa opened 8 years ago

revuwa commented 8 years ago

I'm using AOSP 4.2.2, (and sadly can't upgrade for some reasons). While koush's Superuser seems to work on Android >= 2.2 properly, I wondered, why I just got the message: "Sorry, but your Android is too old for me..." on trying to flash your compiled version on my device. What could I do, to get your great fork on my Android version to work, please?

ildar commented 8 years ago

Superuser (Manage root access) - https https://f-droid.org/app/com.koushikdutta.superuser:// https://f-droid.org/app/com.koushikdutta.superuserf-droid.org https://f-droid.org/app/com.koushikdutta.superuser/app/ https://f-droid.org/app/com.koushikdutta.superuser com.koushikdutta.superuser https://f-droid.org/app/com.koushikdutta.superuser works great on JB. It is the grandpa of this fork.

phhusson commented 8 years ago

As mentioned by ildar, koush's Superuser should work. Here you're referring to superuser.zip? Le 29 nov. 2015 10:15, "revuwa" notifications@github.com a écrit :

I'm using AOSP 4.2.2, (and sadly can't upgrade for some reasons). While koush's Superuser seems to work on Android >= 2.2 properly, I wondered, why I just got the message: "Sorry, but your Android is too old for me..." on trying to flash your compiled version on my device. What could I do, to get your great fork on my Android version to work, please?

— Reply to this email directly or view it on GitHub https://github.com/phhusson/Superuser/issues/24.

revuwa commented 8 years ago

Thanks for you responses.

Jip, koush's Superuser works great, (over this project I was linked to yours here). But koush's Superuser seems not to be maintained anymore, but have some minor security flaws. Just one example here: https://github.com/koush/Superuser/issues/260 So I would love to see an actively developed version on older devices / operating systems, like this one here: http://www.replicant.us/ which uses koush's Superuser embedded. It would be really great if Replicant, (based on AOSP 4.2.2) could update to your version in the future.

Here you're referring to superuser.zip?

Jip, I compared the compiled and built flashable .zip version of yours with the koush's superuser.zip, source: http://download.clockworkmod.com/superuser/superuser.zip

Could you please do something for me, (and/or the Replicant project) here?

phhusson commented 8 years ago

I added #260, but I don't consider it a security flaw alone. An user can always go in Settings and clear data's app to bypass the pin. Possibly we'd need to set Superuser apk system so it's not clearable from settings...

I've tested su on 4.3, it works. I'd expect the same on a 4.2. Do you confirm the superuser.zip doesn't work on a 4.2 custom recovery? (native Android recovery is not supported and has never been. I might support it later) If so, please provide the logs of the recovery, and which recovery it is.

phhusson commented 8 years ago

On which device are you trying that? Does it use standard boot.img format? Can you try http://superuser.phh.me/superuser.zip ?