search

phhusson / Superuser

Keeping koush's Superuser fresh
GNU General Public License v3.0
424 stars 50 forks source link

Make "getting `su binary`" path shorter and more obvious #28

Open ildar opened 8 years ago

ildar commented 8 years ago

It's so great it reached the F-Droid repo. (https://github.com/phhusson/Superuser/issues/3) It's so sad that it behaves so weirdly:

  1. It claims that su binary should be updated. The only option is through the Recovery
  2. Tapping Recovery produces the error. A user is confused. He has no idea where to get the new su binary. Actually although I'm tracing the whole discussion here, but neither I know where I can get the su binary. Please put the su binary somewhere and make the app open that link for downloading. Thanks!
phhusson commented 8 years ago

The su binary alone is useless. I will probably provide a link to http://superuser.phh.me/superuser.zip in app for that.

xenithorb commented 8 years ago

Why not have the app download that, reboot to recovery and flash

0nse commented 8 years ago

@xenithorb I don't think you can reboot and flash without a superuser

xenithorb commented 8 years ago

Ok, I thought I remembered another app doing it that way.

Perhaps then download and present clear instructions to the user that they need to install from a custom recovery the superuser.zip file in a known location like /sdcard/superuser/superuser.zip?

phhusson commented 8 years ago

An app can indeed ask TWRP to apply an update.zip. Though not all users will be using an alternative recovery.