search

phhusson / Superuser

Keeping koush's Superuser fresh
GNU General Public License v3.0
423 stars 50 forks source link

placeholder? What placeholder??? #47

Open ehem opened 8 years ago

ehem commented 8 years ago

I've done the NDK portion of the build, but there is no "placeholder" to be found anywhere. Aside from the references in Superuser/README.md and Superuser/Superuser/assets/update-binary I don't see any placeholder binary anywhere.

While I'm at it, why specify attaching to /system/bin/app_process32? 64-bit builds aren't much more complicated and in the near future some devices might choose not to run /system/app/app_process32 (or run it as a restricted user), while /system/bin/app_process64 could remain in service longer. (noticing all userspace on this device is 64-bit binaries now)

ehem commented 8 years ago

Just in case you hadn't guessed, I'm aware of the stableL branch. The issue is the directions in the README talk about the use of the placeholder, which isn't present in the master branch. Most likely this should be solved by updating the documentation for the master branch.

lbdroid commented 7 years ago

Documentation is out of date. Feel free to submit pull request to update documentation against github.com/seSuperuser (which is now deemed to be upstream repository).