search

phhusson / ims

GNU General Public License v2.0
114 stars 12 forks source link

License? #15

Closed ignoramous closed 9 months ago

ignoramous commented 9 months ago

A license file is missing? May be intentional, and in that case, you can close this bug.

phhusson commented 9 months ago

Right it isn't intentional and I need to fix it before receiving other contributors. Thanks for the reminder

Le Wed Dec 13 01:44:30 GMT+01:00 2023, ignoramous @.***> a écrit :

 A license file is missing? May be intentional, and in that case, you  can close this bug.    —  Reply to this email directly, view it on GitHub  [https://github.com/phhusson/ims/issues/15], or unsubscribe  [https://github.com/notifications/unsubscribe-auth/AAAA4OXHLUFV7SJSIDJOMYLYJD265AVCNFSM6AAAAABASKPWW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTQNZVGYZTOMI].  You are receiving this because you are subscribed to this @.***>

phhusson commented 9 months ago

There, me and @martinetd settled on GPLv2. I added LICENSE file and added SPDX header to the source files. Please check if as far as you know I did everything needed to properly declare the license.

Please note that we'll likely include external subprojects, that might be under other licenses. Those projects will be easy to remove, and have little impact on the feature-set, but I'm not sure we'll make efforts on making it modular.

For instance I've integrated rnnoise to do some Mic quality improvement, which is under the MPL, and I'll integrate EVS support, which only has a proprietary public-source implementation ( https://github.com/wanglihe/3gpp-evs )

ignoramous commented 9 months ago

Thanks. I want to point out that GPLv2 is not compatible with Apache projects (which is majority of AOSP): https://www.apache.org/licenses/GPL-compatibility.html

For a standalone app, GPLv2 is super okay.

skr4n commented 5 months ago

Greetings, I'd like to point out that the SPDX License Identifier used (GPL-2.0) is deprecated and ambiguous. The correct options are GPL-2.0-only or GPL-2.0-or-later

Thanks. I want to point out that GPLv2 is not compatible with Apache projects (which is majority of AOSP): https://www.apache.org/licenses/GPL-compatibility.html

Picking GPL-2.0-or-later here would solve this too as GPLv3 is compatible with Apache-2.0. Happy to see this project under a Copyleft license.