phhusson / ims

GNU General Public License v2.0
101 stars 13 forks source link

Question more then issue? #16

Open sperglord8008s opened 5 months ago

sperglord8008s commented 5 months ago

Sorry if this is a stupid question but how would one incorporate this into a Lineage OS ROM for Exynos Devices? or am i enjoying a pipe dream?

phhusson commented 5 months ago

Just flash AndyYan's LineageOS GSI, then install the apk built from this git, and it works.

TARKZiM commented 5 months ago

Just flash AndyYan's LineageOS GSI, then install the apk built from this git, and it works.

Sorry for asking, I've tried to make it built with LineageOS 20, but not sure if it's designed for QCOM samsung ims stack? Or is it only support Exynos devices now?

Because it won't work on my QCOM Samsung device.

Thanks for your work!

phhusson commented 5 months ago

It supports all SoC vendors across all OEMs for VoWifi. For VoLTE, it works on all SoC vendors across all OEMs except non-Samsung Mediatek.

TARKZiM commented 5 months ago

It supports all SoC vendors across all OEMs for VoWifi. For VoLTE, it works on all SoC vendors across all OEMs except non-Samsung Mediatek.

Ok, Many thanks.

waynea commented 4 months ago

Just flash AndyYan's LineageOS GSI, then install the apk built from this git, and it works.

Sorry for my ignorance here but could you explain.. 1) do I need to flash GSI? I have the official lineageos on my Samsung 10 2) how do I generate an apk to flash. Can I do that with Odin

Thanks for all your work on this

phhusson commented 4 months ago

do I need to flash GSI? I have the official lineageos on my Samsung 10

To the best of my knowledge, the only custom ROMs who did the proper integration of this Floss IMS is TrebleDroid. I'm not aware of official lineageos doing the work to integrate it.

how do I generate an apk to flash. Can I do that with Odin

You don't flash an APK. An apk is just the file format for an Android application. You just install it from a file manager.

jxipaul commented 3 months ago

the only custom ROMs who did the proper integration of this Floss IMS is TrebleDroid.

Newbie here, how involved would the process be to integrate it into a pre-existing rom? Can that even be done, or is it too much to ask? Thanks for your work!

Potatococ commented 3 months ago

hey, newbie here, how do you exactly compile the apk file properly from the github files? can you do a run down complete guide please?

phhusson commented 3 months ago

In your SDK folder, do zip -d ./platforms/android-33/android.jar android/telephony/ims/feature/MmTelFeature.class android/telephony/ims/feature/MmTelFeature\$MmTelCapabilities.class then in Ims folder do bash build.sh

Potatococ commented 3 months ago

In your SDK folder, do zip -d ./platforms/android-33/android.jar android/telephony/ims/feature/MmTelFeature.class android/telephony/ims/feature/MmTelFeature\$MmTelCapabilities.class then in Ims folder do bash build.sh

what is SDK and lms folder? also what softwares do i need to compile it on windows? also, will you add a public apk release?

phhusson commented 3 months ago

There is a current prebuilt at https://treble.phh.me/floss-ims-18.apk

Potatococ commented 3 months ago

There is a current prebuilt at https://treble.phh.me/floss-ims-18.apk

just need to install it normally right? (thanks btw, saves a lot of time!)

phhusson commented 3 months ago

No.

How to install:

Potatococ commented 3 months ago

image which one should i get? also, is trebledroid vanilla android rom? also, it won't work with any other aosp based roms like lineageos and pixelexperience?

sperglord8008s commented 3 months ago

image which one should i get? also, is trebledroid vanilla android rom? also, it won't work with any other aosp based roms like lineageos and pixelexperience?

If not, Is it all sweet to dirty flash treble ROM over Lineage?

sperglord8008s commented 3 months ago

Is this your work also> https://xdaforums.com/t/research-wip-possible-volte-enablement-for-samsung-devices-on-aosp-based-roms.4664947/

phhusson commented 2 months ago

@sperglord8008s It isn't my work no. This is the way we did IMS on all other platforms, I tried to do it on Samsung several times, but failed. It's cool that they managed to do it. Let's hope they can do a stable release. For the moment I looked at the current code, and it's clearly very far from finished (I just hope they won't stop at a half-baked stage where it can't be properly integrated into GSI without giant hacks)

Either way I'll keep the FLOSS IMS way anyway because it is super useful for all devices across the board, both for security, bringing new features, carrier compatibility, long-term device support, etc.