phhusson / platform_frameworks_base

Other
10 stars 32 forks source link

Reintroduce button-backlight (and respective inactivity timeout) #15

Closed PeterCxy closed 3 years ago

PeterCxy commented 3 years ago

The power manager rewrite from Change I1d7a52e98f0449f76d70bf421f6a7f245957d1d7 completely removed support for control of the button backlights, which makes all capacitive buttons out there stay dark. The commit message in that change mentions it hasn't been implemented yet, so this fix should be temporary until upstream does their own implementation

[RC: Updated to 5.0] [PeterCxy: Updated to R, thanks to LineageOS for forward-porting the commit]

Change-Id: I6094c446e0b8c23f57d30652a3cbd35dee5e821a

phhusson commented 3 years ago

it's weird to store light manager on one side, and to store locallight on the other side. It's also weird to call light manager mLight.

But well, if that's as-is in LineageOS, I'll pick it as is

PeterCxy commented 3 years ago

@phhusson It has been like this since the very beginning, e.g. your previous cherry-picks (https://github.com/phhusson/platform_frameworks_base/commit/f745ee456c9a0ce226e681706d12f731a08fcbde).

It's the same in LineageOS today, and in CyanogenMod in the past.