search

phhusson / platform_frameworks_base

Other
10 stars 32 forks source link

Add field to save OriginalOperatorNumeric in CellInfoGsm #6

Closed cheah closed 4 years ago

cheah commented 5 years ago

Fix for phhusson/treble_experimentations#486

phhusson commented 5 years ago

I think hide is the only way not to break the API?

Le mar. 25 juin 2019 à 19:38, penn5 notifications@github.com a écrit :

@penn5 commented on this pull request.

I'd go for @UnsupportedAppUsage rather than @hide https://github.com/hide.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phhusson/platform_frameworks_base/pull/6?email_source=notifications&email_token=AAAA4OR24WTWWEDPN2Z7SWLP4JJYNA5CNFSM4HTTWLX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4TDRDI#pullrequestreview-254163085, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAA4OUGH4QZHXXH6IG4PVDP4JJYNANCNFSM4HTTWLXQ .

penn5 commented 5 years ago

Or both?

cheah commented 5 years ago

Added @UnsupportedAppUsage. The correct way seems to be having both: @hide to prevent Javadoc generation & @UnsupportedAppUsage to restrict app usages.

cheah commented 5 years ago

Urgh. Removed @UnsupportedAppUsage as it doesn't exist in Pie. It was introduced in Q.

phhusson commented 4 years ago

Oh I forgot this sorry. Why is @hide commented?

cheah commented 4 years ago

It's a Javadoc attribute :smile: Hence it's commented.

penn5 commented 4 years ago

...? It got merged?