Closed cheah closed 4 years ago
I think hide is the only way not to break the API?
Le mar. 25 juin 2019 à 19:38, penn5 notifications@github.com a écrit :
@penn5 commented on this pull request.
I'd go for @UnsupportedAppUsage rather than @hide https://github.com/hide.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phhusson/platform_frameworks_base/pull/6?email_source=notifications&email_token=AAAA4OR24WTWWEDPN2Z7SWLP4JJYNA5CNFSM4HTTWLX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4TDRDI#pullrequestreview-254163085, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAA4OUGH4QZHXXH6IG4PVDP4JJYNANCNFSM4HTTWLXQ .
Or both?
Added @UnsupportedAppUsage
.
The correct way seems to be having both: @hide
to prevent Javadoc generation & @UnsupportedAppUsage
to restrict app usages.
Urgh. Removed @UnsupportedAppUsage
as it doesn't exist in Pie. It was introduced in Q.
Oh I forgot this sorry.
Why is @hide
commented?
It's a Javadoc attribute :smile: Hence it's commented.
...? It got merged?
Fix for phhusson/treble_experimentations#486