search

phhusson / platform_frameworks_base

Other
10 stars 32 forks source link

Enable SBC Dual Channel (SBC HD) for better Bluetooth Output. #9

Open mykekfz opened 3 years ago

mykekfz commented 3 years ago

Hello,

Could you please add this to your code. Google intentionally ignore it since it cuts into the margin of APT X. Google doesn't care, they are focused on cripping the useful features of AOSP in favor of creating crappy proprietary systems.

https://android-review.googlesource.com/q/topic:bt-sbc-hd-dualchannel+(status:open%20OR%20status:merged)

Detailed information on the topic can be found here

https://habr.com/en/post/456476/

Kind regards

phhusson commented 3 years ago

Nope. I only do pure AOSP.

The idea of this project is to keep the number of patches over AOSP as low as possible, so that it can be reused by other ROMs. If I start including such patches, merging my patches will become complicated, because the number of conflicts will increase.

I'd be happy to make a fuller-blown AOSP, but I sadly don't have the time for that.

FWIW, your remarks are IMO completely wrong, and probably encumbers your point. SBC is crappy, like batshit crappy. Sure those patches make it less horrific, but it still remains worse than 1995 state of the art! Google doesn't care about Apt-X margin: They merged AAC and LDAC support. AAC is pretty much open.

mirh commented 3 years ago

SBC may be theoretically less efficient than mp3, but if you can push enough bitrate that doesn't matter (it can even be better than aptx in fact) https://lineageos.org/engineering/Bluetooth-SBC-XQ/

With this said, patches are still undergoing review and they haven't been rejected.. It's just that there's not much pushing from either the author or the maintainers.