Fails to build against irssi-1.0.0

[wraeth]

It appears that SSL-related attributes have moved or been removed causing the build to fail.

x86_64-pc-linux-gnu-gcc -O2 -pipe -fomit-frame-pointer -Wformat -Werror=format-security -Wall -I/usr/include/irssi//src/ -I/usr/include/irssi//src/core/ -I/usr/include/irssi//src/fe-common/ -I/usr/include/irssi//src/fe-common/core/ -I/usr/include/irssi//src/fe-text/ -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DUOFF_T_LONG -fPIC -DHAVE_OPENSSL -I/usr/include/quasselc    -c -o quassel-msgs.o quassel-msgs.c
quassel-net.c: In function ‘quassel_server_init_connect’:
quassel-net.c:135:9: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘use_ssl’
  if(conn->use_ssl) {
         ^
quassel-net.c:138:14: error: ‘struct Quassel_SERVER_CONNECT_REC_s’ has no member named ‘use_ssl’
  ret->connrec->use_ssl = 0;
              ^
make: *** [<builtin>: quassel-net.o] Error 1
make: *** Waiting for unfinished jobs....

[ailin-nemui]

https://github.com/cdidier/irssi-xmpp/issues/18#issuecomment-271335175

[phhusson]

Can you check https://github.com/phhusson/quassel-irssi/tree/fix-build-1.0.0 ?

[wraeth]

Thanks, but unfortunately that fails with the same error.

Edit: scratch that, it does resolve it, but fails on other missing SSL-related parameters:

x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -fomit-frame-pointer -I/usr/include/irssi//src/ -I/usr/include/irssi//src/core/ -I/usr/include/irssi//src/fe-common/ -I/usr/include/irssi//src/fe-common/core/ -I/usr/include/irssi//src/fe-text/ -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DUOFF_T_LONG -fPIC -DHAVE_OPENSSL -I/usr/include/quasselc    -c -o quassel-fe-level.o quassel-fe-level.c
irssi/network-openssl.c: In function ‘irssi_ssl_get_iochannel’:
irssi/network-openssl.c:440:38: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘ssl_cert’
  const char *mycert = server->connrec->ssl_cert;
                                      ^
irssi/network-openssl.c:441:38: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘ssl_pkey’
  const char *mypkey = server->connrec->ssl_pkey;
                                      ^
irssi/network-openssl.c:442:38: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘ssl_cafile’
  const char *cafile = server->connrec->ssl_cafile;
                                      ^
irssi/network-openssl.c:443:38: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘ssl_capath’
  const char *capath = server->connrec->ssl_capath;
                                      ^
irssi/network-openssl.c:444:35: error: ‘SERVER_CONNECT_REC {aka struct _SERVER_CONNECT_REC}’ has no member named ‘ssl_verify’
  gboolean verify = server->connrec->ssl_verify;
                                   ^
x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -fomit-frame-pointer -I/usr/include/irssi//src/ -I/usr/include/irssi//src/core/ -I/usr/include/irssi//src/fe-common/ -I/usr/include/irssi//src/fe-common/core/ -I/usr/include/irssi//src/fe-text/ -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DUOFF_T_LONG -fPIC -DHAVE_OPENSSL -I/usr/include/quasselc    -c -o quassel-cfg.o quassel-cfg.c
make: *** [<builtin>: irssi/network-openssl.o] Error 1
make: *** Waiting for unfinished jobs....

Edit 2: pasted wrong snippet

[phhusson]

Oh that's just great...

I'll try to think on how to fix that

[ailin-nemui]

maybe it would be easier if you hadn't to copy so much code from irssi?

[phhusson]

Of course, but I didn't really have much choice.

[ailin-nemui]

the brain-dead solution are more #defines and s/ssl/tls for all the above

[phhusson]

I've opened https://github.com/irssi/irssi/issues/615 for that.

[avently]

@phhusson so how I can build your plugin now? Issue is unresolved as I can see.