search

phhusson / treble_app

An app which will do various stuff for Treble ROMs
68 stars 93 forks source link

Call shell script (see other pull request in phhusson/device_phh_treble) #28

Open fourofspades opened 4 years ago

fourofspades commented 4 years ago

Call shell script.

phhusson commented 4 years ago

The code is fine, but please rebase into just one commit, and make a proper commit message saying this is to remove telephony

fourofspades commented 4 years ago

Do I need to do any more work on this pull request?

phhusson commented 4 years ago

Could you rebase?

fourofspades commented 4 years ago

OK, rebased.

fourofspades commented 4 years ago

Think I have done this correctly, don't really use GIT and rebasing much in my usual GIT usage.

phhusson commented 4 years ago

Not really, there is supposed to be no "Merge " commits

Assuming my remote is origin, and yours is me do this:

git pull --rebase origin master
git push -f me Issue_#1141_TabletMode
phhusson commented 4 years ago

that's still not ok, but I'll merge manually, thanks