phhusson / vendor_hardware_overlay

This includes hardware-specific overlays for Treble ROM
120 stars 569 forks source link

Added redmi note11s (fleur) #684

Closed SysWhiteDev closed 1 year ago

SysWhiteDev commented 1 year ago

i tried pushing the file with original name, but the phone keeps deleting it

SysWhiteDev commented 1 year ago

question, i noticed that the status bar is wrongly sized, like it doesnt et the height of the camera, should the overlay fix this?

phhusson commented 1 year ago

When is it deleted? Right after pushing, or after rebooting? If the later, you can try to do adb shell 'stop;start' rather than rebooting to soft-reboot android without actually rebooting

SysWhiteDev commented 1 year ago

But then wouldn't it delete it if I need to reboot the phone?

phhusson commented 1 year ago

atm you're just testing the overlay though? once you tested it, it gets merged and goes into all GSIs

SysWhiteDev commented 1 year ago

Yea, but i would need to build one then? And I have no idea or the hardware to do that

phhusson commented 1 year ago

No? Just wait for whichever GSI you want to upgrade once your overlay has been merged?

SysWhiteDev commented 1 year ago

I mean, i rly just want it working rn, it would be nice if it got merged in all of them, but this would take time.

SysWhiteDev commented 1 year ago

Just tested this morning, seems that the device removes the .apk with adb shell stop; start too

phhusson commented 1 year ago

How do you check that it's removed?

19 déc. 2022 07:08:14 SysWhite @.***>:

Just tested this morning, seems that the device removes the .apk with adb shell stop; start too

— Reply to this email directly, view it on GitHub[https://github.com/phhusson/vendor_hardware_overlay/pull/684#issuecomment-1357145731], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAAA4OQTTAT6SBIOGA2ESL3WN73U3ANCNFSM6AAAAAATCWQP3E]. You are receiving this because you commented.[Image de pistage][https://github.com/notifications/beacon/AAAA4OQHIM27A4Z5AEVBJMTWN73U3A5CNFSM6AAAAAATCWQP3GWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSQ4RTIG.gif]

SysWhiteDev commented 1 year ago

I check by doing adb shell ls /system/product/overlay/ and check if the file I added is still there

SysWhiteDev commented 1 year ago

how should i check if the overlay its working?

phhusson commented 1 year ago

well you tried to fix stuff in the overlay, check that those things that you tried to fix are fixed?

If you're just asking whether it's loaded, you can run as root lsof |grep /system/product/overlay/name-of-the-overlay-file.apk. If there are matches, then it probably is being loaded