phhusson / vendor_hardware_overlay

This includes hardware-specific overlays for Treble ROM
120 stars 569 forks source link

Update overlays for galaxy A32 and add system ui overlays. #696

Closed ahnet-69 closed 1 year ago

ahnet-69 commented 1 year ago

I made new system ui overlays that actually work! and new configs. Tested the overlays out. they work great.

SysWhiteDev commented 1 year ago

how did you check if the overlay was working? because i have no idea how

ahnet-69 commented 1 year ago

how did you check if the overlay was working? because i have no idea how

i pushed the built apks to my /system/product they seemed to be working and i didnt see any errors in adb logcat. i didnt see any errors about the extra properties that do not exist. so they work jsut fine.

SysWhiteDev commented 1 year ago

sorry if i wasn't clear, but i mean what should the phone do differently if it is really working?

ahnet-69 commented 1 year ago

sorry if i wasn't clear, but i mean what should the phone do differently if it is really working?

i fixed some values which did make an effect. the brightness slider was working way more accurately. i also added a config for biometric sensors because on new td patches fp sensor was being disabled for most users because it allowed pixel devices to boot. this is to compensate for that. i would like to have that in there incase something like this happens again. this fixed it on ricedroid gsi. so there are some changes and system ui overlay also helped! that status bar potrait config was also fixed some wierd placement there. so yes i did not just add unncessary configs. they all help.

ahnet-69 commented 1 year ago

one more thing. just noticed pushing my new overlays into some gsi's fixes face unlock somehow.