search

phi-grib / flame

Modeling framework for eTRANSAFE project
GNU General Public License v3.0
12 stars 10 forks source link

`Control` class should be a set of functions? #81

Closed BielStela closed 5 years ago

BielStela commented 5 years ago

control.py class Control shouldn't be a class since it doesn't use any state given by the instance and all the functions could use model name as parameter. The functions could be in utils.py.

This way we will remove a module and reduce the whole code base complexity and readability.

manuelpastor commented 5 years ago

Control class was required to run networks of models. This is an advanced feature which will require furether documentation. In any case, it is not a priority, so please wait

manuelpastor commented 5 years ago

After reviewing the code I agree that this class is not needed. It has been replaced by a simple "get_parameters" function in utils