search

phi-grib / flame

Modeling framework for eTRANSAFE project
GNU General Public License v3.0
12 stars 10 forks source link

Stats code fix #98

Closed josecarlosgomezt closed 5 years ago

josecarlosgomezt commented 5 years ago

Major code changes in terms of code quality, error handling and documentation for stats folder files. Bug in retrieving the cross-validator fixed. Code simplified.

pep8speaks commented 5 years ago

Hello @josecarlosgomezt! Thanks for submitting the PR.

Line 48:1: W293 blank line contains whitespace Line 56:1: W293 blank line contains whitespace Line 57:1: W293 blank line contains whitespace Line 60:1: W293 blank line contains whitespace Line 64:1: W293 blank line contains whitespace Line 74:17: E128 continuation line under-indented for visual indent Line 100:17: E122 continuation line missing indentation or outdented

Line 52:1: E122 continuation line missing indentation or outdented Line 56:1: E402 module level import not at top of file Line 68:1: W293 blank line contains whitespace Line 74:1: W293 blank line contains whitespace Line 79:72: W291 trailing whitespace Line 80:67: W291 trailing whitespace Line 82:1: W293 blank line contains whitespace Line 90:41: E128 continuation line under-indented for visual indent Line 95:17: E128 continuation line under-indented for visual indent Line 116:61: W291 trailing whitespace Line 120:1: W293 blank line contains whitespace Line 128:1: W293 blank line contains whitespace Line 139:1: W293 blank line contains whitespace Line 149:21: E128 continuation line under-indented for visual indent Line 155:47: W291 trailing whitespace Line 156:25: E127 continuation line over-indented for visual indent Line 160:29: E127 continuation line over-indented for visual indent Line 161:68: W291 trailing whitespace Line 180:54: W291 trailing whitespace Line 181:45: E128 continuation line under-indented for visual indent Line 182:45: E128 continuation line under-indented for visual indent Line 183:45: E128 continuation line under-indented for visual indent Line 184:45: E128 continuation line under-indented for visual indent Line 184:60: W291 trailing whitespace Line 185:45: E128 continuation line under-indented for visual indent Line 189:29: E128 continuation line under-indented for visual indent Line 190:29: E128 continuation line under-indented for visual indent Line 195:29: E128 continuation line under-indented for visual indent Line 196:29: E128 continuation line under-indented for visual indent Line 197:29: E128 continuation line under-indented for visual indent Line 211:58: W291 trailing whitespace Line 216:17: E128 continuation line under-indented for visual indent Line 226:57: W291 trailing whitespace Line 229:60: W291 trailing whitespace Line 230:9: E128 continuation line under-indented for visual indent Line 231:9: E128 continuation line under-indented for visual indent Line 244:60: W291 trailing whitespace Line 245:45: E127 continuation line over-indented for visual indent Line 273:9: E128 continuation line under-indented for visual indent Line 276:13: E128 continuation line under-indented for visual indent Line 277:1: W293 blank line contains whitespace Line 282:1: E266 too many leading '#' for block comment Line 287:1: W293 blank line contains whitespace Line 289:5: E303 too many blank lines (3) Line 293:5: E303 too many blank lines (2) Line 300:5: E303 too many blank lines (2) Line 301:80: E501 line too long (87 > 79 characters) Line 304:5: E303 too many blank lines (2) Line 305:80: E501 line too long (100 > 79 characters) Line 308:5: E303 too many blank lines (2) Line 309:80: E501 line too long (102 > 79 characters) Line 312:5: E303 too many blank lines (2) Line 313:80: E501 line too long (104 > 79 characters) Line 316:5: E303 too many blank lines (2) Line 317:69: W292 no newline at end of file

Line 54:52: W291 trailing whitespace Line 57:1: W293 blank line contains whitespace Line 63:1: W293 blank line contains whitespace Line 68:72: W291 trailing whitespace Line 69:67: W291 trailing whitespace Line 71:1: W293 blank line contains whitespace Line 74:64: W291 trailing whitespace Line 86:1: W293 blank line contains whitespace Line 94:1: W293 blank line contains whitespace Line 105:1: W293 blank line contains whitespace Line 114:25: E127 continuation line over-indented for visual indent Line 139:54: W291 trailing whitespace Line 144:29: E128 continuation line under-indented for visual indent Line 145:29: E128 continuation line under-indented for visual indent Line 151:55: W291 trailing whitespace Line 153:62: W291 trailing whitespace Line 155:1: W293 blank line contains whitespace Line 156:21: E303 too many blank lines (2) Line 157:54: W291 trailing whitespace Line 162:29: E128 continuation line under-indented for visual indent Line 163:29: E128 continuation line under-indented for visual indent Line 165:18: W291 trailing whitespace Line 176:58: W291 trailing whitespace Line 181:17: E128 continuation line under-indented for visual indent Line 193:80: E501 line too long (81 > 79 characters) Line 195:49: E128 continuation line under-indented for visual indent Line 199:29: E127 continuation line over-indented for visual indent Line 215:57: W291 trailing whitespace Line 218:58: W291 trailing whitespace Line 219:9: E128 continuation line under-indented for visual indent Line 220:9: E128 continuation line under-indented for visual indent Line 220:30: W291 trailing whitespace Line 233:46: E127 continuation line over-indented for visual indent Line 252:1: E266 too many leading '#' for block comment Line 257:1: W293 blank line contains whitespace Line 259:5: E303 too many blank lines (3) Line 263:5: E303 too many blank lines (2) Line 270:5: E303 too many blank lines (2) Line 271:80: E501 line too long (87 > 79 characters) Line 274:5: E303 too many blank lines (2) Line 275:80: E501 line too long (100 > 79 characters) Line 278:5: E303 too many blank lines (2) Line 279:80: E501 line too long (102 > 79 characters) Line 282:5: E303 too many blank lines (2) Line 283:80: E501 line too long (104 > 79 characters) Line 286:5: E303 too many blank lines (2) Line 287:69: W292 no newline at end of file

Line 49:1: W293 blank line contains whitespace Line 59:1: W293 blank line contains whitespace Line 75:21: E128 continuation line under-indented for visual indent Line 105:37: E128 continuation line under-indented for visual indent Line 107:52: W291 trailing whitespace Line 108:29: E128 continuation line under-indented for visual indent Line 111:37: E128 continuation line under-indented for visual indent Line 113:52: W291 trailing whitespace Line 114:29: E128 continuation line under-indented for visual indent Line 117:57: W291 trailing whitespace Line 118:29: E128 continuation line under-indented for visual indent Line 134:51: W291 trailing whitespace Line 135:25: E128 continuation line under-indented for visual indent Line 136:1: W293 blank line contains whitespace Line 148:33: E131 continuation line unaligned for hanging indent Line 150:37: E128 continuation line under-indented for visual indent Line 156:53: E128 continuation line under-indented for visual indent Line 168:57: E131 continuation line unaligned for hanging indent Line 176:25: E128 continuation line under-indented for visual indent Line 183:1: E266 too many leading '#' for block comment Line 183:1: E303 too many blank lines (3) Line 188:1: W293 blank line contains whitespace Line 190:5: E303 too many blank lines (3) Line 194:5: E303 too many blank lines (2) Line 201:5: E303 too many blank lines (2) Line 202:80: E501 line too long (87 > 79 characters) Line 205:5: E303 too many blank lines (2) Line 206:80: E501 line too long (100 > 79 characters) Line 209:5: E303 too many blank lines (2) Line 210:80: E501 line too long (102 > 79 characters) Line 213:5: E303 too many blank lines (2) Line 214:80: E501 line too long (104 > 79 characters) Line 217:5: E303 too many blank lines (2) Line 218:69: W292 no newline at end of file

Line 43:1: E302 expected 2 blank lines, found 1 Line 49:1: W293 blank line contains whitespace Line 59:1: W293 blank line contains whitespace Line 66:1: W293 blank line contains whitespace Line 75:21: E128 continuation line under-indented for visual indent Line 106:1: W293 blank line contains whitespace Line 114:80: E501 line too long (80 > 79 characters) Line 118:33: E128 continuation line under-indented for visual indent Line 123:54: W291 trailing whitespace Line 124:25: E128 continuation line under-indented for visual indent Line 124:57: W291 trailing whitespace Line 136:52: W291 trailing whitespace Line 137:25: E128 continuation line under-indented for visual indent Line 150:37: E128 continuation line under-indented for visual indent Line 156:53: E128 continuation line under-indented for visual indent Line 167:37: E131 continuation line unaligned for hanging indent Line 167:55: W291 trailing whitespace Line 174:74: W291 trailing whitespace Line 175:25: E128 continuation line under-indented for visual indent Line 182:1: E266 too many leading '#' for block comment Line 187:1: W293 blank line contains whitespace Line 189:5: E303 too many blank lines (3) Line 193:5: E303 too many blank lines (2) Line 200:5: E303 too many blank lines (2) Line 201:80: E501 line too long (87 > 79 characters) Line 204:5: E303 too many blank lines (2) Line 205:80: E501 line too long (100 > 79 characters) Line 208:5: E303 too many blank lines (2) Line 209:80: E501 line too long (102 > 79 characters) Line 212:5: E303 too many blank lines (2) Line 213:80: E501 line too long (104 > 79 characters) Line 216:5: E303 too many blank lines (2) Line 217:69: W292 no newline at end of file

Line 24:36: W291 trailing whitespace Line 27:44: W291 trailing whitespace Line 41:1: E402 module level import not at top of file Line 42:1: E402 module level import not at top of file Line 43:1: E402 module level import not at top of file Line 44:1: E402 module level import not at top of file Line 45:1: E402 module level import not at top of file Line 46:1: E402 module level import not at top of file Line 47:1: E402 module level import not at top of file Line 48:1: E402 module level import not at top of file Line 49:1: E402 module level import not at top of file Line 50:1: E402 module level import not at top of file Line 51:1: E402 module level import not at top of file Line 52:1: E402 module level import not at top of file Line 52:47: W291 trailing whitespace Line 56:1: E402 module level import not at top of file Line 57:1: E402 module level import not at top of file Line 58:1: E402 module level import not at top of file Line 59:1: E402 module level import not at top of file Line 60:1: E402 module level import not at top of file Line 60:80: E501 line too long (83 > 79 characters) Line 61:1: E402 module level import not at top of file Line 62:1: E402 module level import not at top of file Line 63:1: E402 module level import not at top of file Line 64:1: E402 module level import not at top of file Line 66:1: E402 module level import not at top of file Line 67:1: E402 module level import not at top of file Line 68:1: E402 module level import not at top of file Line 69:1: E402 module level import not at top of file Line 70:1: E402 module level import not at top of file Line 71:1: E402 module level import not at top of file Line 72:1: E402 module level import not at top of file Line 72:80: E501 line too long (81 > 79 characters) Line 73:1: E402 module level import not at top of file Line 74:1: E402 module level import not at top of file Line 75:1: E402 module level import not at top of file Line 76:1: E402 module level import not at top of file Line 77:1: E402 module level import not at top of file Line 79:1: E402 module level import not at top of file Line 86:64: W291 trailing whitespace Line 87:46: W291 trailing whitespace Line 88:1: W293 blank line contains whitespace Line 105:46: W291 trailing whitespace Line 111:1: W293 blank line contains whitespace Line 112:1: W293 blank line contains whitespace Line 162:9: E303 too many blank lines (3) Line 162:30: W291 trailing whitespace Line 167:33: E128 continuation line under-indented for visual indent Line 168:33: E128 continuation line under-indented for visual indent Line 169:33: E128 continuation line under-indented for visual indent Line 174:28: E127 continuation line over-indented for visual indent Line 180:10: E127 continuation line over-indented for visual indent Line 187:30: E127 continuation line over-indented for visual indent Line 191:29: E127 continuation line over-indented for visual indent Line 198:49: W291 trailing whitespace Line 199:37: E128 continuation line under-indented for visual indent Line 200:60: W291 trailing whitespace Line 202:25: E222 multiple spaces after operator Line 202:67: E231 missing whitespace after ',' Line 211:17: E128 continuation line under-indented for visual indent Line 214:9: E266 too many leading '#' for block comment Line 214:75: W291 trailing whitespace Line 215:9: E266 too many leading '#' for block comment Line 224:1: W293 blank line contains whitespace Line 252:70: W291 trailing whitespace Line 263:61: W291 trailing whitespace Line 264:33: E128 continuation line under-indented for visual indent Line 264:49: W291 trailing whitespace Line 265:33: E128 continuation line under-indented for visual indent Line 266:1: W293 blank line contains whitespace Line 276:26: E127 continuation line over-indented for visual indent Line 279:25: E127 continuation line over-indented for visual indent Line 280:20: W291 trailing whitespace Line 290:80: E501 line too long (80 > 79 characters) Line 316:55: W291 trailing whitespace Line 317:33: E127 continuation line over-indented for visual indent Line 322:38: E127 continuation line over-indented for visual indent Line 322:49: W291 trailing whitespace Line 323:38: E127 continuation line over-indented for visual indent Line 323:70: W291 trailing whitespace Line 324:38: E128 continuation line under-indented for visual indent Line 331:25: E127 continuation line over-indented for visual indent Line 340:9: E265 block comment should start with '# ' Line 343:51: W291 trailing whitespace Line 346:57: W291 trailing whitespace Line 347:13: E128 continuation line under-indented for visual indent Line 358:49: W291 trailing whitespace Line 378:17: E122 continuation line missing indentation or outdented Line 379:53: E127 continuation line over-indented for visual indent Line 380:53: E127 continuation line over-indented for visual indent Line 380:68: W291 trailing whitespace Line 381:53: E127 continuation line over-indented for visual indent Line 386:49: E128 continuation line under-indented for visual indent Line 387:45: E128 continuation line under-indented for visual indent Line 393:1: W293 blank line contains whitespace Line 405:55: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 407:55: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 409:55: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 411:55: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 423:25: E127 continuation line over-indented for visual indent Line 436:1: W293 blank line contains whitespace Line 443:25: E127 continuation line over-indented for visual indent Line 449:63: W291 trailing whitespace Line 452:63: W291 trailing whitespace Line 456:18: E127 continuation line over-indented for visual indent Line 460:37: E127 continuation line over-indented for visual indent Line 461:38: E128 continuation line under-indented for visual indent Line 462:39: E128 continuation line under-indented for visual indent Line 469:18: E127 continuation line over-indented for visual indent Line 471:57: W291 trailing whitespace Line 495:43: W291 trailing whitespace Line 502:73: W291 trailing whitespace Line 507:17: E128 continuation line under-indented for visual indent Line 514:29: E128 continuation line under-indented for visual indent Line 516:37: E131 continuation line unaligned for hanging indent Line 526:22: E127 continuation line over-indented for visual indent Line 529:22: E127 continuation line over-indented for visual indent Line 532:59: W291 trailing whitespace Line 534:80: E501 line too long (85 > 79 characters) Line 534:86: W291 trailing whitespace Line 538:25: E127 continuation line over-indented for visual indent Line 540:1: W293 blank line contains whitespace Line 563:13: E122 continuation line missing indentation or outdented Line 564:54: E128 continuation line under-indented for visual indent Line 573:69: W291 trailing whitespace Line 574:21: E128 continuation line under-indented for visual indent Line 576:62: W291 trailing whitespace Line 578:72: W291 trailing whitespace Line 579:21: E128 continuation line under-indented for visual indent Line 583:17: E128 continuation line under-indented for visual indent Line 586:32: W291 trailing whitespace Line 589:21: E128 continuation line under-indented for visual indent Line 590:30: E128 continuation line under-indented for visual indent Line 600:14: E128 continuation line under-indented for visual indent Line 602:14: E128 continuation line under-indented for visual indent Line 604:14: E128 continuation line under-indented for visual indent Line 606:14: E128 continuation line under-indented for visual indent Line 617:24: E211 whitespace before '(' Line 618:50: E202 whitespace before ')' Line 618:52: W291 trailing whitespace Line 619:24: E211 whitespace before '(' Line 620:51: E202 whitespace before ')' Line 620:53: W291 trailing whitespace Line 621:24: E211 whitespace before '(' Line 627:17: E128 continuation line under-indented for visual indent Line 653:57: W291 trailing whitespace Line 655:1: W293 blank line contains whitespace Line 662:14: E111 indentation is not a multiple of four Line 677:13: E128 continuation line under-indented for visual indent Line 696:27: E127 continuation line over-indented for visual indent Line 711:31: E127 continuation line over-indented for visual indent Line 714:31: E127 continuation line over-indented for visual indent Line 717:31: E127 continuation line over-indented for visual indent Line 727:54: W291 trailing whitespace Line 728:33: E128 continuation line under-indented for visual indent Line 729:33: E128 continuation line under-indented for visual indent Line 729:50: W291 trailing whitespace Line 730:33: E128 continuation line under-indented for visual indent Line 736:27: E711 comparison to None should be 'if cond is None:' Line 741:18: E211 whitespace before '('

Line 28:38: E271 multiple spaces after keyword Line 42:16: E231 missing whitespace after ',' Line 44:16: W292 no newline at end of file

Line 29:1: E302 expected 2 blank lines, found 1 Line 31:55: W291 trailing whitespace Line 41:18: E231 missing whitespace after ',' Line 47:33: E128 continuation line under-indented for visual indent Line 47:34: E225 missing whitespace around operator Line 56:33: E128 continuation line under-indented for visual indent Line 56:34: E225 missing whitespace around operator Line 61:21: E272 multiple spaces before keyword Line 65:1: E302 expected 2 blank lines, found 1 Line 73:1: W293 blank line contains whitespace Line 73:1: W391 blank line at end of file