phiamo / MopaBootstrapBundle

Easy integration of twitters bootstrap into symfony2
http://bootstrap.mohrenweiserpartner.de
711 stars 349 forks source link

Fixed sf43 deprecations for future compatibility #1247

Closed linaori closed 3 years ago

linaori commented 5 years ago

When upgrading to 4.3 I got a bunch of deprecations, this PR should fix them.

Summary:

One remaining issue is that the InstallFontCommand is hardcoded to use the web directory, which is configurable in Symfony and defaults to public, but was outside of my scope.

Running phpunit gave me a bunch of risky tests as no assertions were made, so I've tested the changes in my own application:

deguif commented 4 years ago

Any news on this? Symfony 5 is approaching ;)

deguif commented 4 years ago

Ping @isometriks as this is currently critical. Symfony5 was released nearly a year ago ;)

deguif commented 3 years ago

That should now be addressed by #1256 and #1249