phibr0 / obsidian-advanced-toolbar

Advanced Toolbar - Obsidian Plugin | Enhances Obsidian Mobile's Quick Action Toolbar
GNU Affero General Public License v3.0
88 stars 3 forks source link

[Feature Request] Better Sort Order for MultiRow Toolbar #11

Closed SlRvb closed 2 years ago

SlRvb commented 2 years ago

I'd like to use the toolbar with a higher row count, but the order the toolbar displays my icons is somewhat unusable for me. Trying to sort the mobile toolbar to account for that manually would be a nightmare.

If you could calculate the total amount of icons/commands then split that into rows are so that it would order them in the original order, it would be fantastic for using the plugin with multiple rows.

Example of the issue:

IMG_2896|200

Sort order that works in the original 1 line toolbar:

IMG_2897

phibr0 commented 2 years ago

The Problem is that I don't actually rearrange the Icons in some way. I am just setting the height and using display: flex. The flex direction is set as column, because otherwise it wouldn't wrap. Meaning the Buttons would just go on forever to the right.

I already have feature request for allowing someone to long press to rearrange the toolbar which should fix this too right?

SlRvb commented 2 years ago

Ooh I see, I fiddled a little bit with the css and I think I "fixed it". It just scrolls down now instead of sideways 🤣

body.AT-multirow .mobile-toolbar-options-container { 
    flex-flow: row wrap; 
    overflow-y: auto;
}

Not sure if that's something that can or even should be added as a toggle with a note about the vertical scroll, but if you decide not to go with this, feel free to close this issue 👍🏽

phibr0 commented 2 years ago

image

What do you think about this? Forget it, this breaks the drag and drop

melsophos commented 2 years ago

I think that @SlRvb should be the default behavior because it makes much more sense.