search

phibr0 / obsidian-customizable-sidebar

This Plugin allows you to add every Command to Obsidian's Sidebar Ribbon and add Custom Icons.
MIT License
82 stars 8 forks source link

[Enhancement] Edit Existing Command #6

Closed ozntel closed 2 years ago

ozntel commented 3 years ago

Hi, I like your plugin. It is really useful for the commands I use so often! Just throwing an idea as an enhancement. It would be great to be able to edit existing commands. Right now you need to delete the command, restart obsidian and create a new one even if you only want to change the icon. Thanks!

kzhovn commented 2 years ago

@phibr0 I've implemented a version of icon editing in Customizable Menu, which should be pretty quick for me to port over to Customizable Sidebar since it's mostly built on your code. Happy to make a PR if you're interested.

phibr0 commented 2 years ago

That would be pretty cool!

kzhovn commented 2 years ago

I've made the change locally but apparently you can't have multiple forks of one repository (??), so I'm a little stuck on how to get it to you. If you invite me as a collaborator I can push the change on a new branch?

phibr0 commented 2 years ago

I invited you! Go ahead if you are ready

kzhovn commented 2 years ago

Pushed https://github.com/phibr0/obsidian-customizable-sidebar/tree/icon_editing. I made a couple very minor unrelated edits (fixed a typo, set a couple words to lowercase that shouldn't be capitalized in standard English), but I'm happy to undo them if you want to be able to merge the branch without them.

phibr0 commented 2 years ago

Thanks @kzhovn! Just published the new Release