search

phidatahq / phidata

Build AI Agents with memory, knowledge, tools and reasoning. Chat with them using a beautiful Agent UI.
https://docs.phidata.com
Mozilla Public License 2.0
15.58k stars 2.14k forks source link

Local storage for agents #1353

Open traverseda opened 4 weeks ago

traverseda commented 4 weeks ago

As of yet largely untested, and largely AI generated.

Next weekend I'll likely get into more realistic test scenarios as I integrate it into my custom streamlit app.

traverseda commented 4 weeks ago

Despite being AI generated this looks pretty good. Probably could have done this better, faster, and cheaper by hand but it's nice to try some new things occasionally. I suspect I'll run into some issues that do need to be fixed by hand when I go to integrate it with my streamlit app, but the fact that both the build-in sqlite storage and my custom storage's both pass the same test cases give me some hope.

Don't be misled though, this needs a more thorough code review than I've given it. I was expecting the options to mark this as WIP. Please don't merge until either you or I have given it a thorough review.

manthanguptaa commented 3 weeks ago

Hey @traverseda, excellent PR! We usually use cookbooks and they work as tests for us. Can you please move the tests to cookbook. Take example from here https://github.com/phidatahq/phidata/tree/main/cookbook/storage

manthanguptaa commented 1 week ago

Hey @traverseda, are you still working on this PR?

traverseda commented 1 week ago

This is a busy time of year for me at work. I'm unlikely to get to this before the end of the quarter.

ashpreetbedi commented 1 week ago

this is an amazing PR and one that im very excited to merge

traverseda commented 1 week ago

Apologies for not being able to take a closer look at this for a while, my day job is taking up all my programming energy at the moment.