Temperature of 0 treated as NOT_GIVEN OpenAIChat

phidatahq / phidata

Build AI Assistants with memory, knowledge and tools.

https://docs.phidata.com

Mozilla Public License 2.0

11.23k stars 1.67k forks source link

Temperature of 0 treated as NOT_GIVEN OpenAIChat #988

Open Tesla2000 opened 4 months ago

Tesla2000 commented 4 months ago

Greatings I bielieve I have found an issue in you code. Your current way of providing model temperature doesn't account for it being set to 0 and treats it as if it was not set instead. There is a similar story with seed

jacobweiss2305 commented 4 months ago

Ah thank you. Just tested this out


>>> "yes" if 0 else "no"
'no'
``