search

phidatahq / phidata

Build AI Assistants with memory, knowledge and tools.
https://docs.phidata.com
Mozilla Public License 2.0
10.45k stars 1.51k forks source link

Replace if temperatures with if temperature is not None #989

Open Tesla2000 opened 1 month ago

Tesla2000 commented 1 month ago

Fixing https://github.com/phidatahq/phidata/issues/988 for OpenAiChat.

jacobweiss2305 commented 1 month ago 
>>> "yes" if 0 else "no"
'no'

This simple test proves we should check for None instead of None or 0.

Tesla2000 commented 1 month ago

I see you approved. Great, however I am unable to merge. Are more approval required? image