Code conventions: indentation? Space after `if`, `for`, etc?

phiggins42 / has.js

Pure Feature Detection Library

936 stars 59 forks source link

Code conventions: indentation? Space after `if`, `for`, etc? #73

Open mathiasbynens opened 13 years ago

mathiasbynens commented 13 years ago

has.js mostly uses four-space-indents (it seems)m but sometimes two-space-indents are used instead. So which is it? Also, should there be spaces after if, for etc, or not? (Doesn’t look like it, but again, there are a few inconsistencies.)

It would be good to specify the preferred indentation in the README.

jdalton commented 13 years ago

It's 4 spaces per tab. If you see 2 spaces it's prolly my bad :D

phiggins42 commented 13 years ago

yah I've been enforcing the Dojo style guidelines minus "tabs set at 4 spaces", we're just using 4 spaces. No spaces between if( and with( and while( or function blocks, eg: function bar(a, b, c){ ... }

feel free to cleanup and send pull req, otherwise I'll hit some stuff next I have a moment to review everything