search

phiggins42 / has.js

Pure Feature Detection Library
936 stars 59 forks source link

null results for some tests #79

Open paulirish opened 13 years ago

paulirish commented 13 years ago

opening up runTests.html and looking at the results object i get a few results that are null... it seems that is unintended and we'd rather a true boolean.

this does seem related to http://bugs.dojotoolkit.org/ticket/13298 though regardless of philosophy i think these three-ish instances are bugs.

jdalton commented 13 years ago

A null value is valid. It's supposed to be for when the test does not apply. For example the test bug-es5-trim will return null if String#trim does not exist. Because it doesn't exist it can't be buggy (at least that is the thinking behind null).

Which tests return null?

paulirish commented 13 years ago

these do in edge chrome:

["bug-array-concat-arguments", "bug-query-selector-ignores-caps", "activex-enabled"]
jdalton commented 13 years ago

the null for bug-array-concat-arguments is questionable because it only "doesn't apply" when an other bug isn't present but that's less obvious. The others are non-bugs because bug-query-selector-ignores-caps is only a quirks mode issue (maybe tweak the bug name) and activex-enabled only applies to IE.