phil-opp / blog_os

Writing an OS in Rust
http://os.phil-opp.com
Apache License 2.0
15.58k stars 1.07k forks source link

Fix panics caused by misaligned pointer dereferences in "Double Faults" & "Introduction to Paging" #1226

Closed SPuntte closed 1 year ago

SPuntte commented 1 year ago

EDIT 2023-05-31:

I just noticed that post 8 is affected by this as well (as already discussed in #1215) and applied the same fix there.


In the "Double Faults" post, the following code is given as an example:

// trigger a page fault
unsafe {
    *(0xdeadbeef as *mut u64) = 42;
};

Dereferencing 0xdeadbeef as any type larger than u8 is undefined behavior, and a recently merged PR for Rust added runtime debug assertions for this.

Thus, instead of the desired effects, the above code panics with the message 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0xdeadbeef'.

Fortunately, the author chose the value 42 such that it fits in an u8, facilitating an easy fix without the need to invent another funny address that would additionally be 8-byte aligned ;)

The English blog text does not mention the type of the pointer so I assume that neither do the translations.

riking commented 1 year ago

without the need to invent another funny address that would additionally be 8-byte aligned ;)

abad1dea is 2-byte aligned.