search

phil294 / GitLG

A free, interactive Git UI for VSCode
MIT License
155 stars 15 forks source link

Feature Request: Navigation button on scm/title #15

Closed lens0021 closed 1 year ago

lens0021 commented 1 year ago

The navigation button on scm/title is one of my favorite features of vscode-git-graph and even GitKrakenGitLens provides it.

Screenshot from 2023-05-22 10-27-01

I tried to implement this myself and here is my WIP code which is used to make the above image, but I could not figure out how to implement the backend part.

phil294 commented 1 year ago

neat, also didn't know this existed. Your changes work fine for me. I guess you just forgot to do yarn serve in the web folder? (see CONTRIBUTING.md)

you don't have to test this though, we can just merge it now

lens0021 commented 1 year ago

The problem is that if multiple repositories are open, the buttons do not work expectedly. I want each buttons for each repository to act differently(by changing the showing repository in the tab), but all buttons do the same thing.

phil294 commented 1 year ago

ooooh yes of course. It would probably be good to also allow multiple instances of the extension by means of a new config option.

Yeah so for this a repo index needs to be given as an arg to the command somehow and in there, do git.set_selected_repo_index(). But I don't know if repository ordering is consistent. If not, some things need to be rewritten.

I can also do it, but not before Wednesday.

lens0021 commented 1 year ago

It is definitely not urgent! Thank you.