search

phil294 / GitLG

A free, interactive Git UI for VSCode
MIT License
152 stars 12 forks source link

Blame action doesn't work in position:view #77

Open phil294 opened 8 months ago

phil294 commented 8 months ago

https://github.com/phil294/git-log--graph/issues/40#issuecomment-1962294235

Sorry for asking here. I'm not sure if this is an issue or if I'm not understanding it right. I noticed that the editor's context menu has a Blame: Focus last commit at cursor position in graph view option (I was wondering where it came from until I realized here that it comes from git-log-graph). It doesn't seem to do anything when I click on it. Sounds like it should activate the graph view and highlight that specific commit but it doesn't do that. I tried the command git-log--graph.blame-line, nothing reacted to it. I have set "git-log--graph.position": "view" and the view is placed in the bottom panel of the editor. The line at cursor position does have a blame. Other commands like git-log--graph.start can work but only this one doesn't work. Does it require any conditions or settings?

Amanoki commented 8 months ago

@Amanoki no it doesn't require anything, and since v0.1.14 (yesterday), it should also always work reliably. This looks like a bug, I'll just make a new issue out of this #77

Yes looks like it is supposed to be working but it has never worked for me since I installed the extension a couple weeks ago until now. It also doesn't work under "git-log--graph.position": "editor" My VS Code is the latest version. No other useful info to offer beyond these.

stunited-thien commented 4 months ago

same here, I didn't see any git blame feature