phil65 / script.extendedinfo

script.extendedinfo
http://forum.xbmc.org/showthread.php?tid=160558
GNU General Public License v2.0
60 stars 79 forks source link

imdb_id trakt.tv issue #20

Closed Nessus85100 closed 9 years ago

Nessus85100 commented 9 years ago

I use this visible condition to show an overlay if the item in the list is in local libary... <visible>!IsEmpty(ListItem.Property(imdb_id))</visible>

Everything working fine for all list's form TMDB but in trakt.tv list's (Trending items) the property value is always filled (i've checked with an InfoLabel) even for the local items. This happens for both Movies and TV Shows lists.

Thanks Nessus

phil65 commented 9 years ago

? you should use <visible>!IsEmpty(ListItem.Property(dbid))</visible> for the local check.

Nessus85100 commented 9 years ago

Yes, i know about that but i am using the same layouts and an amount of same variables and for the widgets with local items (Recent, Recommended etc) and i would like to avoid the extra conditions about this.

In case you've overlook (like the other time... lol) the imdb id is available in their api... http://docs.trakt.apiary.io/#reference/movies/trending/get-trending-movies

phil65 commented 9 years ago

Again, you use imdb_id for local check? That doesnt make too much sense to me.

phil65 commented 9 years ago

... and I already fetch imdb_id from Trakt: https://github.com/phil65/script.extendedinfo/blob/master/resources/lib/Trakt.py#L85

Nessus85100 commented 9 years ago

... and I already fetch imdb_id from Trakt: https://github.com/phil65/script.extendedinfo/blob/master/resources/lib/Trakt.py#L85

I don't understand... why then the property is not empty for any local items in the trakt.tv list's like they do in the TMBD list's ?

phil65 commented 9 years ago

Me dont understand either ;) imdb_id is defnitely nothing you should use for a local check.

Nessus85100 commented 9 years ago

I am using the same list layout's for all my Movies widgets. If i use ListItem.Property(dbid) then the overlay will show in all my widgets that provide local list's (Recent, Recommended etc). That's why i want to use that check. It's the opposite of checking for local items.

phil65 commented 9 years ago

That wont work. There is no guarantee that trakt / TMDB returns a imdb id at all. What you would need is the dbid property with a different name.

Nessus85100 commented 9 years ago

There is no guarantee that trakt / TMDB returns a imdb id at all.

Aha,,, didn't now that. Sorry.

What you would need is the dbid property with a different name.

Can you please add such property ?

phil65 commented 9 years ago

just a guess: try checkin for property(file)

Nessus85100 commented 9 years ago

Bingo !!!... working like charm... thanks a sorry for the inconvenience !!!.

Out of curiosity, where is that property ?... i don't see it in scripts .py files.

phil65 commented 9 years ago

look harder ;) local_db.py

Nessus85100 commented 9 years ago

Indeed !. Next time i will !!!

Cheers Nessus