search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
27 stars 82 forks source link

make DialogSeekBar.xml visible only when the MusicInfo is explicitly requested #164

Closed joethefox closed 7 years ago

joethefox commented 7 years ago

changed the condition to display the DialogSeekBar.xml during music fullscreen playback to show it only when the MusicInfo is explicitly requested. Custom_1109_TopBarOverlay.xml will follow this rule and so remains untouched.

host505 commented 7 years ago

Why not treating visualisation same as videoplayback? e.g. make line 3 of DialogSeekBar.xml:

<visible>[[Player.Seeking | Player.DisplayAfterSeek | [Player.Paused + !Player.Caching] | Player.Forwarding | Player.Rewinding | Player.ShowInfo | Window.IsActive(fullscreeninfo) | Window.IsActive(videoosd) | Window.IsActive(playerprocessinfo)] + Window.IsActive(fullscreenvideo)] | [Player.Seeking | Player.DisplayAfterSeek | [Player.Paused + !Player.Caching] | Player.Forwarding | Player.Rewinding | Player.ShowInfo | Window.IsActive(musicosd)] + Window.IsActive(visualisation) | !IsEmpty(Player.SeekNumeric)</visible>

That way seekbar is only visible when seeking, ff/rw, pausing, info and osd are active. And for 10" after a new song starts as well.

phil65 commented 7 years ago

Please try https://github.com/phil65/skin.estuary/tree/seekbar

joethefox commented 7 years ago

@phil65 works great, thank you :) Question: it should not now be aligned with the recent PVR changes with kodi master? I mean this commit https://github.com/xbmc/xbmc/commit/328873447ae0d399305c9d326bc8d32cd32718d4

phil65 commented 7 years ago

will align that. the PVR change is already merged to master, right?

joethefox commented 7 years ago

yes, it's already merged.

joethefox commented 7 years ago

solved with https://github.com/phil65/skin.estuary/commit/3676fe97f6b027376868af9df58afaf126b4173b