phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
26 stars 82 forks source link

Video add-ons don't open from favourites #179

Closed DaVukovic closed 7 years ago

DaVukovic commented 7 years ago

If you add a video add-on (Youtube for example) to the favourites it doesn't open at all. It just is doing nothing. The specific part of the log looks like:

09:28:57.169 T:140664174684544   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x000d, modifier: 0x0
09:28:57.222 T:140664174684544   DEBUG: OnKey: return (0xf00d) pressed, action is Select
09:28:57.232 T:140664174684544   DEBUG: Loading settings for addons://user/plugin.video.youtube
09:28:57.233 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers(addons://user/plugin.video.youtube)
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: system rules
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: system rules
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: mms/udp
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: lastfm/shout
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtmp
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: rtsp
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvd
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: dvdimage
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: sdp/asf
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: nsv
09:28:57.233 T:140664174684544   DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: radio
09:28:57.234 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers: matched 0 rules with players
09:28:57.234 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers: adding videodefaultplayer (VideoPlayer)
09:28:57.234 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=0
09:28:57.234 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers: for video=1, audio=1
09:28:57.234 T:140664174684544   DEBUG: CPlayerCoreFactory::GetPlayers: added 1 players
09:28:57.236 T:140664174684544   DEBUG: Radio UECP (RDS) Processor - new CDVDRadioRDSData
09:28:57.236 T:140664174684544  NOTICE: VideoPlayer: Opening: addons://user/plugin.video.youtube
09:28:57.236 T:140664174684544 WARNING: CDVDMessageQueue(player)::Put MSGQ_NOT_INITIALIZED
09:28:57.236 T:140664174684544   DEBUG: LinuxRendererGL: Cleaning up GL resources
09:28:57.236 T:140664174684544   DEBUG: CLinuxRendererGL::PreInit - precision of luminance 16 is 16
09:28:57.236 T:140661378508544   DEBUG: Thread VideoPlayer start, auto delete: false
09:28:57.237 T:140661378508544  NOTICE: Creating InputStream
09:28:57.237 T:140661378508544   ERROR: CVideoPlayer::OpenInputStream - error opening [addons://user/plugin.video.youtube]
09:28:57.237 T:140661378508544  NOTICE: CVideoPlayer::OnExit()
09:28:57.237 T:140661378508544   DEBUG: OnPlayBackStopped: play state was 1, starting 1
09:28:57.237 T:140661378508544   DEBUG: Thread VideoPlayer 140661378508544 terminating
09:28:57.237 T:140664174684544   DEBUG: OnPlayBackStopped: play state was 3, starting 0
09:28:57.237 T:140664174684544   ERROR: PlayMedia could not play media: addons://user/plugin.video.youtube
09:28:57.237 T:140663701694208   DEBUG: CAnnouncementManager - Announcement: OnStop from xbmc
09:28:57.237 T:140664174684544   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x0000, modifier: 0x0

That's reproducable with Kodi 17b7 on Ubuntu 16.04 (intel hardware) and at least with a RPi running LibreELEC. The add-on works fine from the normal add-ons section.

Here is the full log I did later: http://paste.ubuntu.com/23659140/

Tried to open Youtube from favourites at line 1414 Let me know if you need something else.

Greetings

phil65 commented 7 years ago

you didnt add it to favourites from right spot. you need to go to home->add-ons->video add-ons and add it from there via context menu.

DaVukovic commented 7 years ago

I did

I'm not saying that the addons don't appear in favourites. That's fine. They just don't open if I select them.

MilhouseVH commented 7 years ago

@phil65 when you go via the route you suggested, there is no "Add to Favourites" option:

s1

If however you go via Home > Add-ons > Add-on browser > My add-ons > All > YouTube, then there is an "Add to favourites" option:

s2

With this option, having added YouTube to Favourites, when clicking on the YouTube icon in Favourites, it does nothing (it doesn't run, see errors in first post).

DaVukovic commented 7 years ago

bildschirmfoto vom 2016-12-20 15-57-33

you see...the addons are there

phil65 commented 7 years ago

you have to click on "video add-ons" in add-on launcher... then you have it in context menu.

DaVukovic commented 7 years ago

That's exactly what I did.

phil65 commented 7 years ago

your screenshots suggest that you did not.

DaVukovic commented 7 years ago

hell...you're right ;)

If I do it exactly the route you say: addons->video addons->youtube->open context->add to favourites

then it works.

If I go this route: addons->my addons (from the widgets)->video addons->youtube->open context->add to favourites

it does not work.

MilhouseVH commented 7 years ago

Ah yes... you are correct @phil65. I can see it catching people out though!

phil65 commented 7 years ago

see, you just need to read more carefully ;) context menu will get improved in v18.

DaVukovic commented 7 years ago

@phil65

thx much for your time ;)