search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
26 stars 82 forks source link

[POC] alternative settings rework #185

Closed jjd-uk closed 7 years ago

jjd-uk commented 7 years ago

settings_v18_advanced

This is a experimental rework to give similar layout in System as on the Home window.

Advantages of this layout is it gives quick access to the categories for each section of Settings. The main issue I've not been able to solve is to show/hide the category icons to the right of the main menu depending on the selected Setting Level.

Again maybe of interest to @IchabodFletchman and @ronie

phil65 commented 7 years ago

This is a no-go imo. A lot of work which should be done by core (showing appropriate categories) is moved to skinning level here, and since Estuary should be a reference implementation this totally leads into the wrong direction.

jjd-uk commented 7 years ago

Thought I'd experiment with what was possible in case anyone wanted to go this route.

Agreed that showing the appropriate Categories isn't very elegant, and there's currently a major issue where if a Category is only available at a higher Setting Level than is currently set. In this situation the icon link will still be shown even though it can't be used to jump to that Category, not sure that is solvable anyway by having some kind of visibility condition using the currently selected Setting Level.

I'll close this PRthen, but keep the code pushed to my repo if anyway wants to take a further look.