search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
26 stars 82 forks source link

Improvements to music visualization using just artwork #199

Open da-anda opened 7 years ago

da-anda commented 7 years ago

This adds support for the artistslideshow addon. In addition it fixes 3D depths of the viz background. Can remove the later change if desired.

I'd like to add a setting that allows to animate the slideshow in the background, wasn't sure though where to place it best and how to do this correctly. Suggestions welcome.

da-anda commented 7 years ago

I think I managed to add the setting. Just not sure about the label. Should we make it specific to artistslideshow, or do we want it more generic? Also, would you prefer a check if the add-on is installed, and if not ask to install it like you do for other optional add-ons?

phil65 commented 7 years ago

Option should get moved to Custom_1105_MusicOSDSettings.xml, and should probably apply to non-script background as well.

da-anda commented 7 years ago

updated. I tried to combine the two animations, but Kodi seems to have issues with the tweeners and easing in this case (there is no variation of the animation in any form), so I kept the two separate tags.

I added an additional commit that uses the poster/cover as fallback artwork if there is no fanart. It's looking way better than just the colored background, and if somebody doesn't want the artwork it'll also be hidden ofc.

da-anda commented 7 years ago

good to go now?

da-anda commented 7 years ago

bump

dagwieers commented 5 years ago

I learned yesterday that this repository is unmaintained and you need to propose this change to the upstream https://github.com/xbmc/xbmc repository. Good luck !