search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
25 stars 82 forks source link

DialogPVRChannelsOSD elements missing from on screen display (to krypton) #219

Closed linknetx closed 7 years ago

linknetx commented 7 years ago

The progress bar and recording icon are not visible in the Live TV on screen channel display for a channel which is currently being recorded.

Suggest copying the focussed and item layouts completely (for easier future maintenance) from MyPVRChannels and adjusting the widths accordingly. The scrollbar position then also needs a slight adjustment.

phil65 commented 7 years ago

in that case you should move the corresponding code to an include. Please also post before-after screenshots of the change if possible.

linknetx commented 7 years ago

Quote: in that case you should move the corresponding code to an include.

Sorry, but don't understand, what is an include?

Before focussed: before 01

After focussed: after 01

Before non-focussed: before 2

After non-focussed: after 02

linknetx commented 7 years ago

@phil65 This was only intended as a correction to the existing code and not an addition.

I thought that this was the correct location to post this. Please advise if it should be posted elsewhere.

phil65 commented 7 years ago

ping @ksooo , is this valid?

ksooo commented 7 years ago

@phil65 Yeah, confirming the bug and confirming that the fix suggested here does work.

Sidenote: Please be aware that in xbmc master DialogPVRChannelsOSD.xml recently got renamed to DialogPVRChannelGuide.xml. => https://github.com/xbmc/xbmc/pull/11554

phil65 commented 7 years ago

ok, thx. this is for krypton branch though, so should be fine.

ksooo commented 7 years ago

yep.