search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
25 stars 82 forks source link

DialogPVRChannelsOSD elements missing from on screen display (to master) #221

Closed linknetx closed 7 years ago

linknetx commented 7 years ago

The progress bar and recording icon are not visible in the Live TV on screen channel display for a channel which is currently being recorded.

Suggest copying the focussed and item layouts completely (for easier future maintenance) from MyPVRChannels and adjusting the widths accordingly. The scrollbar position then also needs a slight adjustment.

linknetx commented 7 years ago

Quote: in that case you should move the corresponding code to an include.

Sorry, but don't understand, what is an include?

Before focussed: before 01

After focussed: after 01

Before non-focussed: before 2

After non-focussed: after 02

linknetx commented 7 years ago

@phil65 This PR must also be currently valid for the master version of your skin since your master still contains DialogPVRChannelsOSD.xml ?

linknetx commented 7 years ago

@ksooo Your Sidenote for the Krypton PR:

Sidenote: Please be aware that in xbmc master DialogPVRChannelsOSD.xml recently got renamed to DialogPVRChannelGuide.xml. => xbmc/xbmc#11554

If I have understood it correctly it is DialogPVRGuideOSD.xml which has been renamed to DialogPVRChannelGuide.xml and not DialogPVRChannelsOSD.xml

Therefore this PR is still valid since DialogPVRChannelsOSD.xml has not been renamed and still has the bug.

ksooo commented 7 years ago

If I have understood it correctly it is DialogPVRGuideOSD.xml which has been renamed to DialogPVRChannelGuide.xml and not DialogPVRChannelsOSD.xml

Ooops. My fault. You are right. :-)

linknetx commented 7 years ago

@phil65 This is also valid for master branch, exactly the same code changes to DialogPVRChannelsOSD.xml as for the krypton branch.

Also DialogPVRChannelsOSD.xml has not been renamed see comments by @ksooo in previous comment.