search

phil65 / skin.estuary

Public repository for the Kodi default skin "Estuary"
Other
27 stars 82 forks source link

PVR menu suggestions #74

Closed hackthis02 closed 7 years ago

hackthis02 commented 7 years ago

I'm resubmitting this pull request. Since that last one became such a dumper fire.

Home: +Add episode name and reordered info on WeidgetListRecordings Recordings menu: +Moved episode name to under title on sidebar +changed ActualIcon to Icon on sidebar

phil65 commented 7 years ago

https://github.com/phil65/skin.estuary/commit/c4008c8fffb45dbd65eb867e164bc6abaab1d592 doesnt really doesnt make me too confident that you always have the full picture about the scope of your changes... Please do separate PRs for each atomical change.

hackthis02 commented 7 years ago

I guess I don't understand the issue? I had removed ListItem.EpisodeName from the list because I moved it over to the sidebar.

phil65 commented 7 years ago

lot of recordings are only distingishuable by episodename. so if you remove episodename from the list, you often end up with lot of entries with same label and user needs to scroll over each one to find the correct one.

hackthis02 commented 7 years ago

Oh I did that on purpose but I see what your saying. In effect I'm creating the very issue I wanted to fix on the home screen.

hackthis02 commented 7 years ago

I reverted that section of the PR. Thanks for pointing out that issue.