search

phil8192 / ob-analytics

R package intended for visualisation, analysis and reconstruction of limit order book data
Other
149 stars 45 forks source link

Some usability improvements of plotPriceLevels() #23

Closed petr-fedorov closed 6 years ago

petr-fedorov commented 6 years ago

Scale y: a default 'limit price' increment of $0.5 is too small for current Bitcoin price levels - scale is often unreadable. 'price.by' parameter of plotPriceLevels() can be used to set an appropriate value for the increment. Scale x: POSIXct objects are printed using the current timezone set The proposed changes are rather useful when one looks for appropriate values of 'start.time', 'end.time', 'price.from' and 'price.to' parameters.

codecov-io commented 6 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   11.83%   11.83%           
=======================================
  Files          10       10           
  Lines         735      735           
=======================================
  Hits           87       87           
  Misses        648      648
Impacted Files Coverage Δ
R/visualisation.R 0% <0%> (ø) :arrow_up:
R/depth.R 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ff330a...e4966bb. Read the comment docs.

phil8192 commented 6 years ago

thanks Petr!