philbowles / PangolinMQTT

PangolinMQTT - ArduinoIDE client library for ESP8266, ESP32 and STM32-NUCLEO
Other
70 stars 22 forks source link

Update PangolinMQTT.cpp #27

Open sticilface opened 4 years ago

sticilface commented 4 years ago

Comment out Serial object print. ? change it to PANGO_PRINT I note https://github.com/philbowles/PangolinMQTT/issues/8

Is there a reason that the https://github.com/philbowles/PangolinMQTT/blob/300d2b38689f66db6344da2488ea429116555ef5/src/PANGO.cpp#L204

Could also not be changed to

void PANGO::dumphex(Print & output, uint8_t* mem, size_t len,uint8_t W) 

and forgo any dependance on Serial all together. I also do not have a Serial Object for most of my projects and output debugging over a telnet interface. I also use the Serial interface for communication with other devices, ie PJON so printing to it corrupts that communication. I can of course comment out the lines and roll my own hex dump but that means changing it every pull.