search

philbowles / h4plugins

Adds GPIO handling, WiFi, MQTT, Webserver to H4 timer/scheduler. Multi-Platform plugins adding everything needed to create your own multi-function IOT firmware.
46 stars 17 forks source link

fix h4/mqtt/change for brokers not using authentication #16

Closed CatboxParadox closed 3 years ago

CatboxParadox commented 3 years ago

Improves the sanity check in H4P_AsyncMQTT::_change which caused the h4/mqtt/change/ command to fail with error 7 (H4_CMD_PAYLOAD_FORMAT) when attempting to use empty strings as username/password: h4/mqtt/change/192.168.1.24,1883,,

The split() function from H4Utils.cpp discards empty tokens so regardless of the (correct) comma count in the command, the number of tokens passed to _change was 2.

HamzaHajeir commented 3 months ago

Hi @CatboxParadox, Sorry to announce philbowles had passed two years ago, leaving his work in the middle.

Are you still in interest for this library and the whole stack? I've been developing for over a year, you can check my forks and the created environemnt to run easily.

danprof commented 3 months ago

I was very sad when Phil passed. I was following his work closely. I am still interested and I will check it out when I get back home after camping season. Thanks for the update.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Hamza Hajeir @.> Sent: Thursday, August 1, 2024 6:35:47 PM To: philbowles/h4plugins @.> Cc: Subscribed @.***> Subject: Re: [philbowles/h4plugins] fix h4/mqtt/change for brokers not using authentication (#16)

Hi @CatboxParadoxhttps://github.com/CatboxParadox, Sorry to announce philbowles had passed two years ago, leaving his work in the middle.

Are you still in interest for this library and the whole stack? I've been developing for over a year, you can check my forks and the created environemnthttps://github.com/hamzahajeir/h4plugins_env to run easily.

— Reply to this email directly, view it on GitHubhttps://github.com/philbowles/h4plugins/pull/16#issuecomment-2264130606, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOOS2ICA3YKLHWPGFJOSGGLZPKZ4HAVCNFSM6AAAAABL3ODQDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRUGEZTANRQGY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

HamzaHajeir commented 3 months ago

I was very sad when Phil passed. I was following his work closely. I am still interested and I will check it out when I get back home after camping season. Thanks for the update.

You're welcome @danprof, I post the updates in the facebook group H4Plugins once available (philbowles is the only admin to accept requests, but I can enroll friends as a 'Group Expert').

However awaiting your feedback, hope we could advance the project the way Phil deserve.