search

philburk / android-midisuite

Android MIDI test programs and examples.
Apache License 2.0
153 stars 53 forks source link

gradleify project #31

Closed loki666 closed 7 years ago

loki666 commented 7 years ago

first step before publishing on jcenter #30

philburk commented 7 years ago

This looks really good. The original development was using Android.mk and the project was never fully ported to Android Studio. Can you please describe how you did this work? Did you hand build the files like gradlew or did Android Studio generate them? Then I will know how closely I need to review them.

loki666 commented 7 years ago

basically, I recreated the whole project in Android Studio, module by module then moved the .git folder of this repository in my project since I didn't modify the content of the files, git was smart enough to figure move files like a champ!

philburk commented 7 years ago

Yes, git is amazing with recognizing moves. Sounds like a good procedure.

Did you hand build any of the files like gradlew or did Android Studio generate them?

I will check with the Android Studio folks next week and then do the merge. Thanks for doing this work.

loki666 commented 7 years ago

I only edited the build.gradle of the modules to add the dependency to miditools and set the versionCode and versionName.

The rest was created by Android Studio when I created the project and the modules.

On Dec 11, 2016 02:24, "Phil Burk" notifications@github.com wrote:

Yes, git is amazing with recognizing moves. Sounds like a good procedure.

Did you hand build any of the files like gradlew or did Android Studio generate them?

I will check with the Android Studio folks next week and then do the merge. Thanks for doing this work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/philburk/android-midisuite/pull/31#issuecomment-266254263, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYajr6_IBqwgxTo9u6aw_9x0uFO1LKKks5rG1DIgaJpZM4LHHIL .

loki666 commented 7 years ago

should be ok

philburk commented 7 years ago

Thanks for doing this work. It needed to be done.