Show passkeys in the help dialog, and use a legend to improve discoverability

philc / vimium

The hacker's browser.

https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb

MIT License

22.99k stars 2.47k forks source link

Show passkeys in the help dialog, and use a legend to improve discoverability #1500

Open mrmr1993 opened 9 years ago

mrmr1993 commented 9 years ago

Proposal:

show shortcuts overridden by passkeys in a different colour in the help dialog
add a legend to the help dialog, citing "global mappings" and "mappings disabled by passkeys".
- This will indicate to users that there is the passkey functionality.
- It makes it easier to discover what impact passkeys are having.
- We can add a link in the legend to the wiki/an internal page that describes what passkeys are, how to use them, and some extra details (eg. that a number prefix lets you still use the command).

smblott-github commented 9 years ago

Not a bad idea. I'd tone it down a bit, though. Suggest no need to add a legend. Just using a suitable greyed-out colour should be enough to do the trick. Or, at least, try just that in the first instance.

mrmr1993 commented 9 years ago

no need to add a legend

I agree that we should prototype without to start with.

However, I think long term we should consider adding one:

it makes the fetaure more discoverable (preventing eg. #1497)
we can easily add a link which has extra info, like how to use them/the number prefix functionality.
we currently have a bit of space on the RHS of the help dialog, but no plans to add any more commands.

smblott-github commented 8 years ago

Bump. This is still a good idea.