philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.44k stars 2.49k forks source link

Documentation inconsistency about "open link" #1876

Closed james64 closed 9 years ago

james64 commented 9 years ago

Hey,

Reality f - open link in new tab F - open link in current tab

Documentation (by ? key) f - open link in current tab F - open link in new tab

This should be fixed either in documentation or in a code.

I love this plugin!!!

mrmr1993 commented 9 years ago

This sounds suspiciously like #761; are you holding <shift> while you type the hint chatacters?

Doing so toggles between those two modes, which can make them seem inverted, since the intention was that the characters would be entered in lower case by default.

james64 commented 9 years ago

I am not sure what "while you type the hint characters" means but this is what I tried right now step by step:

1) f + => link opened in new tab 2) ? => hint table opened 3) shift pressed => no visible effect 4) => hint table closed 5) f + => link opened in new tab

Please let me know if I misunderstood or if there is anything else I can try for you to see if it is an issue or not.

mrmr1993 commented 9 years ago

I am not sure what "while you type the hint characters" means

I meant while you are in link hints mode typing the characters that appear in a hint to select it.

I don't understand what that list means, sorry. Although, this line:

3) shift pressed => no visible effect

seems like an issue; the mode should change, and the HUD's text should be updated accordingly.

james64 commented 9 years ago

The list is a description of what I do with the plugin and the effects what I see. More verbose version: 1) I press f and choose a link. Then the link is opened in new tab 2) Then I press ? which opens hint table 3) Then I press shift which has no visible effect 4) Then I close hint table by escape key 5) Then I press f and choose a link which again opens the link in new tab as in number 1

Now I have noticed that some words were removed from my first list so it makes less sence. Sorry for that. I hope this verbose version is more readable. I would like to take this to a point were we confirm a bug or not. So again, if I can help...

james64 commented 9 years ago

sorry, I closed the issue by accident. Reopened now...

mrmr1993 commented 9 years ago

1) I press f and choose a link.

This is the stage where <shift> is relevant. Breaking it down:

Are you pressing <shift> at any point while activating a link hint?

james64 commented 9 years ago

ok we have it :) The marks are displayed as capitals so I typed them as capitals therefore pressing shift. It works now. Thank you for your activity. Now I am closing this...