philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.51k stars 2.49k forks source link

Shouldn't ESC always go to commands mode? #2529

Open mimooh opened 7 years ago

mimooh commented 7 years ago

After I create new tab (t) with vimium the cursor it positioned in address bar and I am in insert mode. In firefox plugins (e.g. vimperator) I could leave to commands mode with ESC and pressing 't' would open another tab. Vimium doesn't exit with ESC - the 't' is inserted as a character in address bar. Can I enable ESC escaping somehow?

smblott-github commented 7 years ago

Once the cursor is in Chrome's omnibox, there's no programmatic way to get the focus back in the page. Tab works, though; I think.

(But I recommend this.)

mimooh commented 7 years ago

Ok, thanks! I will do with tab instead of ESC.

-- Karol Kreński tel. 517-302-055

Once the cursor is in Chrome's omnibox, there's no programmatic way to get the focus back in the page. Tab works, though; I think.

(But I recommend this.)

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/philc/vimium/issues/2529#issuecomment-306152479

chrysn commented 7 years ago

could this be implemented on firefox? the restriction against programmatic interaction with the omnibar doesn't seem to apply to the firefox' address box.

lydell commented 7 years ago

@chrysn As far as I know Firefox’s location bar has the same restrictions as Chrome’s.

jonniestuefer commented 7 years ago

@lydell: didn't VimFX process the ESC key in the location bar though?

lydell commented 7 years ago

@jonniewhite Yes it did! That’s because VimFx is a legacy extension. They could do anything. It is the new extensions (WebExtensions) that have the same restrictions as Chrome.

chrysn commented 4 years ago

Is there any particular item in bugzilla where one can leave whatever "This issue affects me as well" markers they use to get this fixed? Searching around there gives a lot of almost-but-not-quite duplicates up to 20 years old, but I found none that's concrete and actionable to Firefox devs.

gdh1995 commented 4 years ago

Another extension like https://chrome.google.com/webstore/detail/new-tab-url/njigpponciklokfkoddampoienefegcl / https://chrome.google.com/webstore/detail/newtab-adapter/cglpcedifkgalfdklahhcchnjepcckfn is needed.

chrysn commented 4 years ago

That would solve the concrete issue of the new tab having its focus in the address bar, but not the generic issue of this thread that a press of escape in any situation should bring them to command mode.

gdh1995 commented 4 years ago

Then it's an impossible task for a plain web extension.

---Original--- From: "chrysn"<notifications@github.com> Date: Sat, Jan 25, 2020 00:18 AM To: "philc/vimium"<vimium@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Dahan Gong"<gdh1995@qq.com>; Subject: Re: [philc/vimium] Shouldn't ESC always go to commands mode? (#2529)

That would solve the concrete issue of the new tab having its focus in the address bar, but not the generic issue of this thread that a press of escape in any situation should bring them to command mode.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.