search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.16k stars 2.48k forks source link

Sometimes the hint-mode generate duplicates #2835

Open ghost opened 6 years ago

ghost commented 6 years ago

When that happens Vimium cannot decide which link to follow and get stuck. I tried changing the letters and the problem came back.

smblott-github commented 6 years ago

What do you mean by "duplicates"? Perhaps a screenshot might help?

ghost commented 6 years ago

By duplicates, I mean that two links received the same letters. So link 1 got: "SR", and link 2 got: "SR". So when I type "sr", Vimium becomes undecided and get stuck.

I resolved the issue by adding more letters, reducing (I think) the probability of two links receiving the same letter. But I'll put the old letters again and try to reproduce.

And also, thanks a lot for Vimium. It totally changed the way I use Chrome and Firefox!

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Livre de vírus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail. <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

ghost commented 6 years ago

Here you go.

I was using the characters for hint mode. But I don't think they're the problem because I used them for ages on Chrome with no issues.

ghost commented 6 years ago

I think I forgot the attachment.

2017-11-24 3:47 GMT-03:00 Davi Ramos davilopes.cine@gmail.com:

Here you go.

I was using the characters for hint mode. But I don't think they're the problem because I used them for ages on Chrome with no issues.

mrmr1993 commented 6 years ago

Delete one of the rs from your link hint characters. We don't check them for duplicates, so we're using both to generate hints, and then we can't narrow the hints properly.

hackel commented 5 years ago

I was experiencing this issue with Vimium as well, and thanks to this issue discovered that I had accidentally added an extra w to my hint keys. Please add a simple validator to the options page that will warn about/prevent from entering duplicate keys. This definitely would have saved me a lot of unwarranted frustration!

azzamsa commented 2 years ago

Having the same issue today. I am agree with Hackel idea. We need to put some validation for duplicate letter.