search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.02k stars 2.47k forks source link

Links in Iframe shows up on link hint even out of viewport #3515

Open richyliu opened 4 years ago

richyliu commented 4 years ago

Describe the bug Links (clickable elements) in an iframe shows up on the link hint (have a link hint marker) even if they are not visible in the viewport

To Reproduce Steps to reproduce the behavior:

  1. Go to any url with an iframe with buttons, like https://www.justinguitar.com/songs/eagles-hotel-california-chords-tabs-guitar-lesson-bs-624
  2. Scroll to the very bottom
  3. Press f (to open link-hint mode)
  4. Scroll to the top
  5. All the buttons in the Youtube iframe have a hint marker

Include a screenshot if applicable.

Browser and Vimium version Firefox 73.0.1 on macOS Catalina 10.15.3

This bug matters because on some pages, there are a lot of youtube iframes but not a lot of clickable links visible at a time. This means that when I press f for link-hinking, I have to type 2 or 3 characters to select the link instead of just 1.

gdh1995 commented 4 years ago

There has been a pull request of #2912 from smb to solve this but it has been closed @philc .